Include classifier in label if present #467
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is, I have a bzl file with a function that returns a list of all our artifacts. The function is called for both the artifacts attr of maven_install in the WORKSPACE and in another rule where I pass
[artifact(a) for a in get_rje_artifacts()]
as inputs to a custom rule we have. I also use strict_visibilityWhat happened was that for the artifact that has a classifier, the label returned wasn't valid and so my custom rule failed to build.
I was able to fix it like this.